Skip to content

Commit

Permalink
fix(custom): move onDropdownInputChange prop for FilterSearch story t…
Browse files Browse the repository at this point in the history
…o args

move executeFilterSearch check to be outside a callback

J=BACK-2765
TEST=manual
  • Loading branch information
Jeffrey-Rhoads17 committed Jan 24, 2024
1 parent d7b485e commit bd614cb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions tests/components/FilterSearch.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,16 @@ const meta: Meta<typeof FilterSearch> = {
}
},
args: {
label: 'Filter'
label: 'Filter',
onDropdownInputChange: undefined,
}
};
export default meta;

export const Primary: StoryFn<FilterSearchProps> = (args) => {
return (
<SearchHeadlessContext.Provider value={generateMockedHeadless(mockedHeadlessState)}>
<FilterSearch {...args} searchFields={searchFields} onDropdownInputChange={undefined} />
<FilterSearch {...args} searchFields={searchFields} />
</SearchHeadlessContext.Provider>
);
};
Expand Down
2 changes: 1 addition & 1 deletion tests/components/FilterSearch.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,7 @@ describe('search without section labels', () => {
renderFilterSearch({ searchFields: searchFieldsProp, onDropdownInputChange: mockedOnDropdownInputChange});
userEvent.type(screen.getByRole('textbox'), 'a');
await waitFor(() => expect(mockedOnDropdownInputChange).toHaveBeenCalledTimes(1));
() => expect(executeFilterSearch).toHaveBeenCalledTimes(0);
expect(executeFilterSearch).toHaveBeenCalledTimes(0);
})
});

Expand Down

0 comments on commit bd614cb

Please sign in to comment.