Answers -> Search #243

ElemelonWind · 2022-07-19T15:34:06Z

Version 0.2.0-beta.243

@yext/answers-react-components is now @yext/search-ui-react!

Changes

Exported a string representing the content path to files in component lib that uses tailwind classnames. (Export a content path for user's tailwind config #193)
Trimmed/edited various CSS classes interfaces. (trim alternative verticals css classes interface #189, Update AppliedFiltersCssClasses #190, Jest tests for RangeInput component #191, removed labelContainer from pagination CSS class #194, removed inputContainer, sectionContainer, and dropdownContainer from FilterSearch CSS class #196, Rename CSS class interface properties container and loading #197, Merge title and description styles for DirectAnswer #198, Update NumericalFacetsCssClasses #200, Update SearchBar CSS class #202)
Made hovering over FilterSearch autocomplete suggestions trigger a highlight on the selected option and fixed its width/padding. (added hover styling to "option" #203, Fixed FilterSearch dropdown width and padding #205)
Removed allowPagination prop from VerticalResults (Removed allowPagination prop from VerticalResults #217, Remove allowPagination follow up #219)
Updated StandardFacets to optionally display the number of results associated with each facet option. (Display counts for StandardFacets #226, make option counts optional #248)
Added a 'clear filter' feature for 'clear min and max' button in RangeInput. (add clear filter feature for 'clear min and max' button in RangeInput #227)
Added a range to the ResultCount that describes the range of results currently displayed by Pagination. (Show pagination info in results count #228)
Replaced onSubmit with dropdownItemProps in RenderEntityPreviews interface. (SearchBar Screenreader Fixes #225, Update docs for RenderEntityPreviews #238)
Separated recent searches in verticals to keep their recent search histories separate. (Separate recent searches in verticals #242)
Removed links from AlternativeVerticals and deleted UniversalLink interface. (remove links in AlternativeVerticals #229)
@yext/answers-headless-react has been renamed to @yext/search-headless-react, and has been replaced by such as a peer dependency. (Answers -> Search #243)

Bugfixes

When label is undefined, FilterSearch does not display default 'filter' label (Made 'filter' not show up when label is undefined #201)
Fixed DropdownMenu tabbing and selecting behavior (Clicking outside dropdown triggers onSelect #206, fixed dropdown menu tabbing #207)
Fixed a bug where clicking the ApplyFiltersButton did not reset the pagination offset. (Fix ApplyFiltersButton offset #213)
Fixed linebreak bug in resultsCount (fixed line break bug in resultsCount #218)
Fixed a bug where range input static filters were removed when selecting/de-selecting facet options with different fieldIds. (Fix static range filter bug #224)
Fixed LocationBias mobile styling (Fix location bias mobile styling #221)
Fixed ThumbsFeedback issues of not having a default width and height, as well as rotation issue with the thumbs-down button. (fix ThumbsFeedback issues #233)
Fixed inputPrefix collision issue and tooltip location in RangeInput. (fix inputPrefix collision issue #232, fix rangeInput tooltip location #234)
Fixed a bug where facets were not being reset when applying a filter from FilterSearch with searchOnSelect=true. (Reset facets on searches from FilterSearch #236)

* edited package.json and mentions of old name in readme * test site renames * fix typo

merge with main.

coveralls · 2022-07-19T15:54:00Z

Coverage remained the same at 84.448% when pulling f658f80 on feature/answers-to-search into 7dbb88e on main.

* renamed core imports * replaced headless-react * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * rename SearchCore.ts * fixed capitlization of variables * fix variable names * test site package.json * test site package-lock and nits * fix renaming * Automated update to repo's documentation from github action * addressed more nits * reverted package.json * reverted packagelock * test site packagelock * packagelock updates Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

ElemelonWind · 2022-07-20T16:36:52Z

Coveralls is acting up :( Will rerun in an hour or so!

nmanu1

can you update the PR description with the changes?

ElemelonWind · 2022-07-20T17:20:33Z

can you update the PR description with the changes?

I don't think anything other than the name (and the internal imports/variables) was changed, how should I say that?

nmanu1 · 2022-07-20T17:26:18Z

I don't think anything other than the name (and the internal imports/variables) was changed, how should I say that?

You can mention that headless-react was renamed, so now we have search-headless-react as a peer dependency instead of answers-headless-react

nmanu1

If we're making a new beta version, the package.json version should be updated. And we probably want to add the other changes since the last beta version in the PR description/release notes

ElemelonWind · 2022-07-20T17:29:43Z

If we're making a new beta version, the package.json version should be updated. And we probably want to add the other changes since the last beta version in the PR description/release notes

Where can I find all the other changes?

nmanu1 · 2022-07-20T17:31:31Z

Where can I find all the other changes?

If you look in the commit history for main, you can see all the commits since the last beta PR (#184) was merged in

ElemelonWind · 2022-07-20T18:01:41Z

Where can I find all the other changes?

If you look in the commit history for main, you can see all the commits since the last beta PR (#184) was merged in

Updated, but I think it looks a bit messy- are there any that I don't need to mention?

nmanu1 · 2022-07-20T18:05:47Z

Updated, but I think it looks a bit messy- are there any that I don't need to mention?

For the CSS class interface updates, I don't think you need to list them all individually. Maybe just mention that we trimmed some of those interfaces and then list all the relevant PRs. You might also be able to group some of the fixes by component to make it more streamlined

ElemelonWind · 2022-07-20T18:12:19Z

Updated, but I think it looks a bit messy- are there any that I don't need to mention?

For the CSS class interface updates, I don't think you need to list them all individually. Maybe just mention that we trimmed some of those interfaces and then list all the relevant PRs. You might also be able to group some of the fixes by component to make it more streamlined

edited!

nmanu1 · 2022-07-20T18:29:45Z

the latest commit on main (#248) should also be added in the description. it can be grouped with the third point under Changes about the StandardFacets count

ElemelonWind · 2022-07-20T18:32:36Z

the latest commit on main (#248) should also be added in the description. it can be grouped with the third point under Changes about the StandardFacets count

Done :)

ElemelonWind · 2022-07-20T18:34:11Z

Coveralls still isn't working :(

nmanu1 · 2022-07-20T18:37:46Z

I think these PRs would also be good to include in the description: #193, #201, #203, #205

ElemelonWind · 2022-07-20T18:41:45Z

I think these PRs would also be good to include in the description: #193, #201, #203, #205

added!

nmanu1 · 2022-07-20T18:44:58Z

A couple more PRs to add: #194 and #198 (these can go with the other css trimming PRs), and #197 (also kind of related)

nmanu1 · 2022-07-20T18:47:45Z

Coveralls still isn't working :(

looks like they're having an outage: https://status.coveralls.io/

alextaing · 2022-07-20T18:51:38Z

I think they're back up!

## Version 0.2.0-beta.243 `@yext/answers-react-components` is now `@yext/search-ui-react`! ### Changes - Exported a string representing the content path to files in component lib that uses tailwind classnames. (#193) - Trimmed/edited various CSS classes interfaces. (#189, #190, #191, #194, #196, #197, #198, #200, #202) - Made hovering over `FilterSearch` autocomplete suggestions trigger a highlight on the selected option and fixed its width/padding. (#203, #205) - Removed `allowPagination` prop from `VerticalResults` (#217, #219) - Updated `StandardFacets` to optionally display the number of results associated with each facet option. (#226, #248) - Added a 'clear filter' feature for 'clear min and max' button in `RangeInput`. (#227) - Added a range to the `ResultCount` that describes the range of results currently displayed by `Pagination`. (#228) - Replaced `onSubmit` with `dropdownItemProps` in `RenderEntityPreviews` interface. (#225, #238) - Separated recent searches in verticals to keep their recent search histories separate. (#242) - Removed links from `AlternativeVerticals` and deleted `UniversalLink` interface. (#229) - `@yext/answers-headless-react` has been renamed to `@yext/search-headless-react`, and has been replaced by such as a peer dependency. (#243) ### Bugfixes - When `label` is undefined, `FilterSearch` does not display default 'filter' label (#201) - Fixed `DropdownMenu` tabbing and selecting behavior (#206, #207) - Fixed a bug where clicking the `ApplyFiltersButton` did not reset the pagination offset. (#213) - Fixed linebreak bug in `resultsCount` (#218) - Fixed a bug where range input static filters were removed when selecting/de-selecting facet options with different `fieldId`s. (#224) - Fixed `LocationBias` mobile styling (#221) - Fixed `ThumbsFeedback` issues of not having a default width and height, as well as rotation issue with the thumbs-down button. (#233) - Fixed `inputPrefix` collision issue and tooltip location in `RangeInput`. (#232, #234) - Fixed a bug where facets were not being reset when applying a filter from `FilterSearch` with `searchOnSelect=true`. (#236)

ElemelonWind and others added 2 commits July 19, 2022 11:33

Answers -> Search 1: package.json + some readme (#239)

9279f47

* edited package.json and mentions of old name in readme * test site renames * fix typo

Merge branch 'main' into feature/answers-to-search

67c35ff

merge with main.

ElemelonWind and others added 2 commits July 20, 2022 12:13

merged with main

1a1cd64

ElemelonWind marked this pull request as ready for review July 20, 2022 16:36

ElemelonWind requested a review from a team as a code owner July 20, 2022 16:36

nmanu1 reviewed Jul 20, 2022

View reviewed changes

update version

710ee2a

nmanu1 reviewed Jul 20, 2022

View reviewed changes

ElemelonWind added 3 commits July 20, 2022 14:18

version changes

a3c4773

merge w main

26790a6

fix error

f658f80

yen-tt approved these changes Jul 20, 2022

View reviewed changes

ElemelonWind merged commit 22960c4 into main Jul 20, 2022

ElemelonWind deleted the feature/answers-to-search branch July 20, 2022 19:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Answers -> Search #243

Answers -> Search #243

ElemelonWind commented Jul 19, 2022 •

edited

coveralls commented Jul 19, 2022 •

edited

ElemelonWind commented Jul 20, 2022

nmanu1 left a comment

ElemelonWind commented Jul 20, 2022

nmanu1 commented Jul 20, 2022

nmanu1 left a comment •

edited

ElemelonWind commented Jul 20, 2022

nmanu1 commented Jul 20, 2022

ElemelonWind commented Jul 20, 2022

nmanu1 commented Jul 20, 2022

ElemelonWind commented Jul 20, 2022

nmanu1 commented Jul 20, 2022

ElemelonWind commented Jul 20, 2022

ElemelonWind commented Jul 20, 2022

nmanu1 commented Jul 20, 2022

ElemelonWind commented Jul 20, 2022

nmanu1 commented Jul 20, 2022

nmanu1 commented Jul 20, 2022

alextaing commented Jul 20, 2022

Answers -> Search #243

Answers -> Search #243

Conversation

ElemelonWind commented Jul 19, 2022 • edited

Version 0.2.0-beta.243

Changes

Bugfixes

coveralls commented Jul 19, 2022 • edited

ElemelonWind commented Jul 20, 2022

nmanu1 left a comment

Choose a reason for hiding this comment

ElemelonWind commented Jul 20, 2022

nmanu1 commented Jul 20, 2022

nmanu1 left a comment • edited

Choose a reason for hiding this comment

ElemelonWind commented Jul 20, 2022

nmanu1 commented Jul 20, 2022

ElemelonWind commented Jul 20, 2022

nmanu1 commented Jul 20, 2022

ElemelonWind commented Jul 20, 2022

nmanu1 commented Jul 20, 2022

ElemelonWind commented Jul 20, 2022

ElemelonWind commented Jul 20, 2022

nmanu1 commented Jul 20, 2022

ElemelonWind commented Jul 20, 2022

nmanu1 commented Jul 20, 2022

nmanu1 commented Jul 20, 2022

alextaing commented Jul 20, 2022

ElemelonWind commented Jul 19, 2022 •

edited

coveralls commented Jul 19, 2022 •

edited

nmanu1 left a comment •

edited