Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visual coverage test in Github Actions #339

Merged
merged 5 commits into from
Nov 18, 2022
Merged

Conversation

yen-tt
Copy link
Contributor

@yen-tt yen-tt commented Nov 17, 2022

In addition to the changes in the workflow PR, this up updates run-tests github action and coverage github action to pass mapbox api key so visual coverage test works as expected.

J=SLAP-2467
TEST=auto

see that run-tests github action and coverage github action passed -- looked into the logs, no false positive / errors related to visual coverage.

@yen-tt yen-tt added the wip label Nov 17, 2022
@yen-tt yen-tt requested a review from a team as a code owner November 17, 2022 19:50
@coveralls
Copy link

coveralls commented Nov 17, 2022

Coverage Status

Coverage increased (+1.3%) to 85.696% when pulling 396b051 on dev/fix-coverage into 3748b15 on develop.

@github-actions
Copy link
Contributor

Current unit coverage is 88.84839650145773%
Current visual coverage is 77.54279959718026%
Current combined coverage is 89.50437317784257%

yen-tt added a commit to yext/slapshot-reusable-workflows that referenced this pull request Nov 18, 2022
the issue with coverage test in search-ui-react repo stems from errors caused within the visual tests from storybook due to missing mapbox API key. This is also an issue when running test workflow where mapbox related visual tests failed due to missing mapbox API key (it also failed silently / test github action "passed" when there are tests failed -- that will be address in this [item](https://yexttest.atlassian.net/browse/SLAP-2459)).

J=SLAP-2467
TEST=auto

- see that coverage GH now works as expected in this search-ui-react PR: yext/search-ui-react#339
- see that mapbox errors in test GH in search-ui-react no longer appear in this PR: yext/search-ui-react#339
@yen-tt yen-tt changed the title test Fix visual coverage test in Github Actions Nov 18, 2022
@yen-tt yen-tt removed the wip label Nov 18, 2022
@yen-tt yen-tt merged commit c7e2d78 into develop Nov 18, 2022
@yen-tt yen-tt deleted the dev/fix-coverage branch November 18, 2022 15:30
yen-tt added a commit that referenced this pull request Nov 18, 2022
In addition to the changes in the [workflow PR](yext/slapshot-reusable-workflows#24), this up updates run-tests github action and coverage github action to pass mapbox api key so visual coverage test works as expected.

J=SLAP-2467
TEST=auto

see that run-tests github action and coverage github action passed -- looked into the logs, no false positive / errors related to visual coverage.
nmanu1 pushed a commit that referenced this pull request Dec 2, 2022
In addition to the changes in the [workflow PR](yext/slapshot-reusable-workflows#24), this up updates run-tests github action and coverage github action to pass mapbox api key so visual coverage test works as expected.

J=SLAP-2467
TEST=auto

see that run-tests github action and coverage github action passed -- looked into the logs, no false positive / errors related to visual coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants