-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HierarchicalFacet #373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR includes the following changes: - Add support for HierarchicalFacet in Facets. - Add unit tests for singular facet components. - Add Facets to PeoplePage. J=BACK-2223 TEST=auto,manual Ran unit tests. Manually checked the behavior of Facets on PeoplePage.
Current unit coverage is 89.17808219178082% |
benmcginnis
reviewed
May 22, 2023
benmcginnis
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd also like Connor to take a 👀
cea2aj
reviewed
May 22, 2023
cea2aj
reviewed
May 22, 2023
cea2aj
reviewed
May 22, 2023
cea2aj
reviewed
May 22, 2023
cea2aj
reviewed
May 22, 2023
cea2aj
reviewed
May 22, 2023
benmcginnis
approved these changes
May 23, 2023
Merged
cea2aj
added a commit
that referenced
this pull request
Jun 29, 2023
# Version 1.3.0 ### Features - Introduce new Facet components including the new Facets (#360), StandardFacet (#370), NumericalFacet (#375), and HierarchicalFacet (#373) components which support more customizability than the previous Facet components. - Support the new RichTextV2 (Lexical) and Markdown fields which have been converted to HTML as FeaturedSnippetDirectAnswers (#379) - Remove the Yext logo from the search bar (#376) - Deprecate LocationBias (#338) component in favor of the new Geolocation component (#336) ### Bug fixes - Improve the UX of the search bar when long autocomplete text is returned which includes the truncation of long text (#378)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
J=BACK-2223
TEST=auto,manual
Ran unit tests. Manually checked the behavior of Facets on PeoplePage.