Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HierarchicalFacet #373

Merged
merged 5 commits into from
May 23, 2023
Merged

Add HierarchicalFacet #373

merged 5 commits into from
May 23, 2023

Conversation

EmilyZhang777
Copy link
Contributor

@EmilyZhang777 EmilyZhang777 commented May 19, 2023

This PR includes the following changes:

  • Add support for HierarchicalFacet in Facets.
  • Add prop onlyRenderChildren.
  • Add unit tests for singular facet components.
  • Add Facets to PeoplePage.

J=BACK-2223
TEST=auto,manual

Ran unit tests. Manually checked the behavior of Facets on PeoplePage.

This PR includes the following changes:
- Add support for HierarchicalFacet in Facets.
- Add unit tests for singular facet components.
- Add Facets to PeoplePage.

J=BACK-2223
TEST=auto,manual

Ran unit tests. Manually checked the behavior of Facets on PeoplePage.
@EmilyZhang777 EmilyZhang777 requested a review from a team as a code owner May 19, 2023 17:00
@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023

Current unit coverage is 89.17808219178082%
Current visual coverage is 77.22117202268431%
Current combined coverage is 89.79452054794521%

@coveralls
Copy link

coveralls commented May 19, 2023

Coverage Status

Coverage: 85.973% (+0.1%) from 85.832% when pulling 8fb783d on dev/hierarchical-facet into f936f9b on develop.

etc/search-ui-react.api.md Outdated Show resolved Hide resolved
src/components/Facets.tsx Outdated Show resolved Hide resolved
src/components/Facets.tsx Outdated Show resolved Hide resolved
Copy link
Member

@benmcginnis benmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd also like Connor to take a 👀

src/components/Facets.tsx Outdated Show resolved Hide resolved
@EmilyZhang777 EmilyZhang777 merged commit e9183f3 into develop May 23, 2023
19 of 27 checks passed
@EmilyZhang777 EmilyZhang777 deleted the dev/hierarchical-facet branch May 23, 2023 16:26
@cea2aj cea2aj mentioned this pull request Jun 29, 2023
cea2aj added a commit that referenced this pull request Jun 29, 2023
# Version 1.3.0

### Features
- Introduce new Facet components including the new Facets (#360), StandardFacet (#370), NumericalFacet (#375), and HierarchicalFacet (#373) components which support more customizability than the previous Facet components. 
- Support the new RichTextV2 (Lexical) and Markdown fields which have been converted to HTML as FeaturedSnippetDirectAnswers (#379)
- Remove the Yext logo from the search bar (#376)
- Deprecate LocationBias (#338) component in favor of the new Geolocation component (#336)

### Bug fixes
- Improve the UX of the search bar when long autocomplete text is returned which includes the truncation of long text (#378)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants