Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop into Main #424

Closed
wants to merge 12 commits into from
Closed

Merge develop into Main #424

wants to merge 12 commits into from

Conversation

EmilyZhang777
Copy link
Contributor

No description provided.

nmanu1 and others added 12 commits December 12, 2023 17:33
Merge main (v1.4.0) into develop
Merge main (v1.4.1) into develop
expose a callback prop to be called everytime after input changes in the FilterSearch component.
This enables greater customization for our Locators that are built using FilterSearch primarily

J=BACK-2765
TEST=manual
…havior, add documentation

specify a type for the props passed into onDropdownInputSelect and pass back the searchFields used
in the FilterSearch component so we can properly remove/keep the right filters

J=BACK-2765
TEST=manual
…pdownInputChange is specified

ensure executeFilterSearch is not called in test when onDropdownInputChange is supplied

J=BACK-2765
TEST=manual
…o args

move executeFilterSearch check to be outside a callback

J=BACK-2765
TEST=manual
This PR addresses the following vulnerabilities under test-site:

bump webpack version to 5.90.0
remove real live api key
J=VULN-37163,VULN-38428
TEST=auto

Ran npm run test. Spun up the test site and confirmed the pages are working.
@EmilyZhang777 EmilyZhang777 requested a review from a team as a code owner February 1, 2024 19:55
Copy link
Contributor

@nmanu1 nmanu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't merge directly into master because there are other changes on develop that need to go in a new minor version

@coveralls
Copy link

Coverage Status

coverage: 85.523% (+0.02%) from 85.508%
when pulling 4b3339a on develop
into d9e5ff4 on main.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

Current unit coverage is 92.65223955712129%
Current visual coverage is 78.38862559241706%
Current combined coverage is 93.158953722334%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants