Allow custom afterDropdownInputFocus on FilterSearch #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current unit coverage is 92.20456802383316% |
Jeffrey-Rhoads17
approved these changes
Mar 15, 2024
nmanu1
reviewed
Mar 15, 2024
nmanu1
reviewed
Mar 15, 2024
nmanu1
reviewed
Mar 18, 2024
nmanu1
reviewed
Mar 18, 2024
nmanu1
reviewed
Mar 18, 2024
EmilyZhang777
changed the title
EmilyZhang777
changed the title
nmanu1
reviewed
Mar 18, 2024
nmanu1
approved these changes
Mar 18, 2024
Merged
sahilvaidya
added a commit
that referenced
this pull request
May 15, 2024
### Features - Added a custom `afterDropdownInputFocus` prop to the `FilterSearch` component that is called after focus enters the input. This can be used, for example, to fire analytics events when a user clicks into the `FilterSearch` input. (#432)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a param so that callers can pass in a custom afterDropdownInputFocus method for FilterSearch's input box. This request was brought up to allow analytics event logging upon clicking on the input box.
This change also bump the version to 1.6.0-beta.432.
J=TECHOPS-11352
TEST=auto, manual
Ran
npm run test. Made suretest-sitestill works without a custom afterDropdownInputFocus method.Used my local
search-ui-reactin the client's repo. Verified clicking into the input box triggers an analytics event and selecting an option from the dropdown properly hides it.https://drive.google.com/file/d/1-kIYMU5TQAB2CzLxhSFpfbIJFqWhRJAR/view?usp=sharing