Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WCAG github action to accept mapbox API key #22

Merged
merged 3 commits into from
Nov 16, 2022
Merged

Conversation

yen-tt
Copy link
Contributor

@yen-tt yen-tt commented Nov 16, 2022

When testing wcag in search-react-ui repo, the mapbox API key is required to use Mapbox GL in storybook. Updated the workflow to optionally accept a mapbox API key as an env variable for the build step.

J=SLAP-2458
TEST=manual

tested in this PR: yext/search-ui-react#331, where wcag error An API access token is required to use Mapbox GL. is no longer present after using the workflow from this branch.

@yen-tt yen-tt requested a review from a team as a code owner November 16, 2022 15:43
Copy link
Contributor

@nmanu1 nmanu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description just needs to be tweaked now that it's not included in the run step, but otherwise lgtm!

@yen-tt yen-tt merged commit cced072 into main Nov 16, 2022
@yen-tt yen-tt deleted the dev/mapbox-key-wcag branch November 16, 2022 16:09
@yen-tt yen-tt mentioned this pull request Nov 16, 2022
yen-tt added a commit that referenced this pull request Nov 16, 2022
- Update WCAG github action to accept mapbox API key (#22)
yen-tt added a commit to yext/search-ui-react that referenced this pull request Nov 17, 2022
paired with the changes in this [PR](yext/slapshot-reusable-workflows#22) in WCAG workflow, this PR updates the WCAG github action in the repo to pass in the mapbox key. Also updated the wcag test to exclude checking elements coming from mapbox canvas container as any potential violations coming from there is outside of our repo's control.

WCAG github action also run on pull request to feature branch now.

J=SLAP-2458
TEST=auto

see that WCAG github action now passes
yen-tt added a commit to yext/search-ui-react that referenced this pull request Nov 18, 2022
paired with the changes in this [PR](yext/slapshot-reusable-workflows#22) in WCAG workflow, this PR updates the WCAG github action in the repo to pass in the mapbox key. Also updated the wcag test to exclude checking elements coming from mapbox canvas container as any potential violations coming from there is outside of our repo's control.

WCAG github action also run on pull request to feature branch now.

J=SLAP-2458
TEST=auto

see that WCAG github action now passes
nmanu1 pushed a commit to yext/search-ui-react that referenced this pull request Dec 2, 2022
paired with the changes in this [PR](yext/slapshot-reusable-workflows#22) in WCAG workflow, this PR updates the WCAG github action in the repo to pass in the mapbox key. Also updated the wcag test to exclude checking elements coming from mapbox canvas container as any potential violations coming from there is outside of our repo's control.

WCAG github action also run on pull request to feature branch now.

J=SLAP-2458
TEST=auto

see that WCAG github action now passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants