Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Open Authorization Configuration #183

Merged
merged 3 commits into from Dec 29, 2021
Merged

chore: Add Open Authorization Configuration #183

merged 3 commits into from Dec 29, 2021

Conversation

yezz123
Copy link
Owner

@yezz123 yezz123 commented Dec 28, 2021

A Startlette middleware for authentication through oauth2's via a secret key, which is often used to add authentication and authorization to a web application that interacts with an API on behalf of the user.

This middleware is intended to be used when the application relies on an external tenant (e.g. Microsoft AD) for authentication.

@yezz123 yezz123 added the enhancement New feature or request label Dec 28, 2021
@yezz123 yezz123 self-assigned this Dec 28, 2021
@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #183 (f58bb59) into main (af2aaf2) will increase coverage by 0.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   92.67%   93.10%   +0.43%     
==========================================
  Files          19       21       +2     
  Lines         573      609      +36     
  Branches       50       51       +1     
==========================================
+ Hits          531      567      +36     
  Misses         33       33              
  Partials        9        9              
Impacted Files Coverage Δ
authx/__init__.py 100.00% <100.00%> (ø)
authx/middleware/Oauth2.py 100.00% <100.00%> (ø)
authx/middleware/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af2aaf2...f58bb59. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Dec 28, 2021

This pull request introduces 1 alert when merging fbc4f0a into a2ef89d - view on LGTM.com

new alerts:

  • 1 for Unused import

@yezz123 yezz123 mentioned this pull request Dec 28, 2021
@pull-request-quantifier-deprecated

This PR has 242 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Large
Size       : +241 -1
Percentile : 64.2%

Total files changed: 10

Change summary by file extension:
.py : +234 -1
.txt : +3 -0
.sample : +4 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 29, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.50%.

Quality metrics Before After Change
Complexity 0.00 ⭐ 0.00 ⭐ 0.00
Method Length 24.00 ⭐ 27.00 ⭐ 3.00 👎
Working memory 3.00 ⭐ 3.00 ⭐ 0.00
Quality 97.67% 97.17% -0.50% 👎
Other metrics Before After Change
Lines 13 14 1
Changed files Quality Before Quality After Quality Change
authx/init.py 97.67% ⭐ 97.17% ⭐ -0.50% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@yezz123 yezz123 merged commit a3f6843 into main Dec 29, 2021
@yezz123 yezz123 deleted the Middleware branch December 29, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant