Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username Validation Fixed #238

Merged
merged 2 commits into from
Jun 19, 2022
Merged

Username Validation Fixed #238

merged 2 commits into from
Jun 19, 2022

Conversation

YogeshUpdhyay
Copy link
Contributor

Fixes #237

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 19, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 2.54 ⭐ 2.54 ⭐ 0.00
Method Length 46.29 ⭐ 46.29 ⭐ 0.00
Working memory 6.89 🙂 6.89 🙂 0.00
Quality 76.32% 76.32% 0.00%
Other metrics Before After Change
Lines 137 137 0
Changed files Quality Before Quality After Quality Change
authx/models/user.py 76.32% ⭐ 76.32% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Jun 19, 2022

Codecov Report

Merging #238 (b9fb25f) into main (53b8341) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   91.20%   91.20%           
=======================================
  Files          54       54           
  Lines        1785     1785           
=======================================
  Hits         1628     1628           
  Misses        157      157           
Impacted Files Coverage Δ
authx/models/user.py 78.82% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53b8341...b9fb25f. Read the comment docs.

Copy link
Owner

@yezz123 yezz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @YogeshUpdhyay 🙏🏻

@yezz123 yezz123 merged commit 65b2643 into yezz123:main Jun 19, 2022
@yezz123
Copy link
Owner

yezz123 commented Jun 19, 2022

@all-contributors add @YogeshUpdhyay for bug

@allcontributors
Copy link
Contributor

@yezz123

I've put up a pull request to add @YogeshUpdhyay! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong username validation UserInRegister model
2 participants