Skip to content
This repository has been archived by the owner on Mar 5, 2019. It is now read-only.

Undo icon white residue in dark theme #4

Open
yfdyh000 opened this issue Feb 19, 2015 · 5 comments
Open

Undo icon white residue in dark theme #4

yfdyh000 opened this issue Feb 19, 2015 · 5 comments
Projects

Comments

@yfdyh000
Copy link
Owner

No description provided.

@Mazzibig
Copy link

Try to fix icon
toolbar_fx4

@yfdyh000
Copy link
Owner Author

@Mazzibig Thank you, it looks a little better, I would consider merging it.
I look forward to an automatic contrast and transparent icon, similar style.

@yfdyh000
Copy link
Owner Author

yfdyh000 added a commit that referenced this issue Mar 23, 2016
This reverts commit e34ab33.

* The icon size requires some CSS adaptation for Fx34 & Fx28.
@yfdyh000
Copy link
Owner Author

I appreciate this icon, but encountered some technical problems for adapting it to the earlier versions. I don't want to abandon them, although this decision is not immutable.

@yfdyh000 yfdyh000 reopened this Mar 23, 2016
@yfdyh000
Copy link
Owner Author

I have tried to limit its size using the max-width and max-height for Fx28 & Fx43 and earlier, but it always has some problems, such as too large, too small or scaling glitch on toolbar.

Fx44 and later seems to be working well, because https://bugzilla.mozilla.org/show_bug.cgi?id=1184651, but I don't know its condition for Win7 and Mac.

Welcome any patches, but I hope that it works well for Fx28~latest versions, including small icon mode on/off.

p.s. 64x64 of the icon (cropped):
toolbar_fx4_64

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Improve
Appearance
Development

No branches or pull requests

2 participants