Issues + Requests

[rayman89]

First i wanted you to thank you for keeping the add-on alive and for having this page to have contact with the users then i wanted to tell you that I noticed some issues for example that when having the option to load anything (links bookmarks history search results etc) in a new background tab and having an add-on to not load background tabs like for example "auto unload tab" or "suspend tab" causes the browser to create a blank page with no favicon or title but when you click on it the address is written on the address bar but if you press enter to load the address or any other address or try to reload the page nothing happens.

When you protect the tab there is a display bug that shows when you click on an other tab instead of showing the lock it displays the image that firefox uses to show the close tab button on the tab (shows a white x with a transparent background followed by a bold x with a red background and a not bold x with a red background.

Also I wanted to request the menu option to copy url/title/url+title of the current tab/selected tabs/all tabs; the option to select all tabs to the right and all tabs to the left; the option to save all the selected tabs's pages, the option to bookmark them, duplicate them, move them to an specific window, move them to a new group/specific group and i don't know if this can be requested to you or the the unload add-on developer but I think it would be useful to have to be able to have a menu option when selecting multiple tabs to be able to unload/resume them.

Would be nice also that all the options that change the background tab color are shaped to match the australis rounded tab look and that the transparency of the tabs affects not only the title but the transparency of the background color and the outline or have an option to define the transparency of each one individually and would be also nice to be able to define how thick the outline is.

[yfdyh000]

Thank you for writing such a long report.

1. Sorry, I cannot reproduce it using like "auto unload tab" or "suspend tab". maybe I have misunderstood, I'm not sure what is the problem.
2. I do not see a red background. Are you use the default Firefox theme?
3. Sounds good, but the project basically don't accept (achieve) feature requests for now, I don't have enough energy and skills for development.
   • p.s. Shift+Click or Ctrl+Click to select tabs; https://addons.mozilla.org/firefox/addon/unloadtab/ have a "Unload Other Tabs" menu;
4. As above, maybe have other extensions can do that.

[rayman89]

Thanks for your quick response

1. What i meant is that while using add-ons that have the option to not load new tabs that are opened in the background (some examples of this kind of add-on are "auto unload tab" and "suspend tab" https://addons.mozilla.org/en-US/firefox/addon/auto-unload-tab/ https://addons.mozilla.org/en-US/firefox/addon/suspend-tab/) and selecting on your add-on the option to load anything (links bookmarks history search results etc) in a new background tab then that issue happens.

2. Is not a red background of the tab. The issue is that the image of the lock changes for an other image if that tab is not the tab you are currently on (for example if you have 2 protected tabs the tab you are on displays the lock and the other one displays the other image I described) Here is a pic of that http://www.imagebam.com/image/b5481b434557284 I'm not using any theme.

[yfdyh000]

1. ok, I see the issue, will track it.
2. thanks, but I don't see it on Fx40 Win8.1, the icon work fine.
   p.s. although it will disappear on Fx41+ due to a bug, I will track it.

What is your OS, is Windows?

[rayman89]

I tested a bit further on issue 2 and I noticed it happens when you use a black lightweight theme (personas) and the black "x" to close the tab is replaced with a white "x" it doesn't happen on the current tab cause the actual tab is highlighted and keeps the black "x".

The same happens on the dev version of firefox cause the dev theme is dark. (Probably the missing icon has to do with something related to this as well cause the current tab on dev firefox keeps the white "x").

[yfdyh000]

ok, I see, will fix it as soon as possible.

[rayman89]

Thanks a lot.

[rayman89]

It's not fixed on the new version.

To recreate the issue put this lightweight theme or any other dark lightweight theme https://addons.mozilla.org/es/firefox/addon/dark-fox-18066/ protect 2 tabs and check the icons The protected tab you are on has the proper icon and the other one not.

[yfdyh000]

Do you already installed the https://github.com/yfdyh000/tabutils/releases 2015.09.10.
I don't see this issue on Fx41~43 with 2015.09.10 and "Dark Fox" installed.

[rayman89]

Yes i have the latest add-on version

I tested and on dev version is working properly but on ff 40 is not D=
(both were tested on a clean profile)

[yfdyh000]

See the commit, some difficult problems I did not find a way to fix it.

[rayman89]

1.5.2015.09.11 fixes the icon issue. Thanks a lot.

I'm not a developer but if it's not something very complex you could tell me what you did to fix the icon issue on 40 and dev and I could look into fixing 39 and older if you need me to. The rest of the stuff is way above my league.

[yfdyh000]

Fx39 and earlier applied a CSS rule, I find it hard to override it.

#TabsToolbar[brighttext] .tab-close-button:not(:hover):not([selected="true"]) {
  -moz-image-region: rect(0, 64px, 16px, 48px) !important;
}```

[rayman89]

And what does ff40 has and how did you overwrite it on ff 40?

[yfdyh000]

I don't see it in Fx40, maybe where it has been removed. not an exact conclusion.

[rayman89]

What i've found that you may or may not know is that previous versions of firefox had a faulty detection for dark themes and when firefox detected it was too dark it used the white icons/text on recent versions I think that is defined by the lightweight theme. The code now for the "simptoms" you described it seems that it's set for the icon to only display when that happens so you can make it appear on both cases like you did when you fixed the issue on 40 it wont be the same code for the fix but the idea is probably the same.

[yfdyh000]

I just don't know how to cover it, to get a higher priority.
https://developer.mozilla.org/en-US/docs/Web/CSS/Specificity

I just also found that we can modify it with JavaScript, but this may is too much trouble for keep the original function.
//Compatibility with themes in tabutils.js.

[rayman89]

I know that your intention was to override it but I was trying to see things in an other way if that's hard that's why I suggested that other way to do it.

An other way I was thinking is to add it like TMP does without replacing the close tab button that gives this errors and adding new icons over the tab. IDK if possible but you could see the lines on their add-on and use them with other icons this way you do not depend on firefox values to modify but rather add new stuff.

BTW Does this also happen with ESR38? if not they could use 38 if they prefer an older version cause 41 comes in 10 days and some hours.

[yfdyh000]

It is very difficult, which basically requires rewriting the entire TU, I look forward to but no energy and confidence to do this at present.

Yes, also happen in Firefox Setup 38.0.1esr. But this is an appearance bug only, and not a common case (Dark theme + 38 + Protection tab)，I don't think it is necessary to take time to study it.

[rayman89]

Sorry i wish i knew more to be more helpful.

[yfdyh000]

Do not worry, "help wanted" label for everyone. Expect a miracle come of it.

[def00111]

With my "Auto Unload Tab" add-on, load background tabs will NOT work correctly with your add-on.
This is the javascript error i got in the browser console:
Utils is not defined chrome://tabutils/content/tulib.js line 105 > eval:17:0
This error does NOT appear when my "Load background tabs" setting is enabled (Keep background tabs loading).
So, its YOUR add-on, thats breaking my "Load background tabs" setting.

[def00111]

Ok, i have fixed issue 1 now.

[rayman89]

Thanks def00111. Did you fix this modifying your add-on or this add-on?