Skip to content

Commit

Permalink
Merge pull request #185 from jbienkowski311/es6
Browse files Browse the repository at this point in the history
ES6 refactor
  • Loading branch information
DavidVujic committed Jul 19, 2019
2 parents 43018e7 + 89ddc3c commit c456cd1
Show file tree
Hide file tree
Showing 24 changed files with 791 additions and 1,091 deletions.
2 changes: 0 additions & 2 deletions .eslintignore
@@ -1,4 +1,2 @@
/scripts/*.js
/lib/*.js
/tests_integration/*.js
/deps/**/*.js
4 changes: 3 additions & 1 deletion .eslintrc.json
Expand Up @@ -9,6 +9,8 @@
"airbnb-base"
],
"rules": {
"indent": ["error", 4]
"indent": ["error", 4],
"no-console": ["error", { "allow": ["info", "warn", "error"] }],
"no-multi-assign": 0
}
}
2 changes: 2 additions & 0 deletions README.md
Expand Up @@ -66,6 +66,7 @@ try {
* a_get_children ( path, watch, child_cb )
* a_get_children2 ( path, watch, child2_cb )
* a_set ( path, data, version, stat_cb )
* a_sync ( path, value_cb )
* a_delete`_` ( path, version, void_cb )
* (trailing `_` is added to avoid conflict with reserved word `_delete_` since zk_promise.js strips off prefix `a_` from all operations)
* a_set_acl ( path, version, acl, void_cb )
Expand All @@ -87,6 +88,7 @@ try {
* data_cb : function ( rc, error, stat, data )
* child_cb : function ( rc, error, children )
* child2_cb : function ( rc, error, children, stat )
* value_cb : function ( rc, error, value )
* void_cb : function ( rc, error )
* watch_cb : function ( type, state, path )
* acl_cb : function (rc, error, acl, stat)
Expand Down
17 changes: 0 additions & 17 deletions lib/fs-promise.js

This file was deleted.

7 changes: 7 additions & 0 deletions lib/helper.js
@@ -0,0 +1,7 @@
const deprecationLog = (className, methodName) => {
console.warn(`ZOOKEEPER LOG: ${className}::${methodName} is being deprecated!`);
};

exports = module.exports = {
deprecationLog,
};
3 changes: 2 additions & 1 deletion lib/index.js
@@ -1,3 +1,4 @@
module.exports = require('./zookeeper');
module.exports.ZooKeeper = module.exports; // for backwards compatibility

module.exports.ZooKeeper = module.exports; // for backwards compatibility
module.exports.Promise = require('./zk_promise');

0 comments on commit c456cd1

Please sign in to comment.