Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 refactor #185

Merged
merged 14 commits into from Jul 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions .eslintignore
@@ -1,4 +1,2 @@
/scripts/*.js
/lib/*.js
/tests_integration/*.js
/deps/**/*.js
4 changes: 3 additions & 1 deletion .eslintrc.json
Expand Up @@ -9,6 +9,8 @@
"airbnb-base"
],
"rules": {
"indent": ["error", 4]
"indent": ["error", 4],
"no-console": ["error", { "allow": ["info", "warn", "error"] }],
"no-multi-assign": 0
}
}
2 changes: 2 additions & 0 deletions README.md
Expand Up @@ -66,6 +66,7 @@ try {
* a_get_children ( path, watch, child_cb )
* a_get_children2 ( path, watch, child2_cb )
* a_set ( path, data, version, stat_cb )
* a_sync ( path, value_cb )
* a_delete`_` ( path, version, void_cb )
* (trailing `_` is added to avoid conflict with reserved word `_delete_` since zk_promise.js strips off prefix `a_` from all operations)
* a_set_acl ( path, version, acl, void_cb )
Expand All @@ -87,6 +88,7 @@ try {
* data_cb : function ( rc, error, stat, data )
* child_cb : function ( rc, error, children )
* child2_cb : function ( rc, error, children, stat )
* value_cb : function ( rc, error, value )
* void_cb : function ( rc, error )
* watch_cb : function ( type, state, path )
* acl_cb : function (rc, error, acl, stat)
Expand Down
17 changes: 0 additions & 17 deletions lib/fs-promise.js

This file was deleted.

7 changes: 7 additions & 0 deletions lib/helper.js
@@ -0,0 +1,7 @@
const deprecationLog = (className, methodName) => {
console.warn(`ZOOKEEPER LOG: ${className}::${methodName} is being deprecated!`);
};

exports = module.exports = {
deprecationLog,
};
3 changes: 2 additions & 1 deletion lib/index.js
@@ -1,3 +1,4 @@
module.exports = require('./zookeeper');
module.exports.ZooKeeper = module.exports; // for backwards compatibility

module.exports.ZooKeeper = module.exports; // for backwards compatibility
module.exports.Promise = require('./zk_promise');