-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Node 12 support #187
Merged
Merged
Add Node 12 support #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would very much appreciate to get feedback on this PR. My C++ skills are not good, and I am not sure about the new code written follow guidelines or handles memory issues correctly. Maybe @kuebk can have a look? Also @jbienkowski311 ? |
jbienkowski311
approved these changes
Jul 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will make it possible to build this project in Node.js 12. Both deprecated and removed V8 features have been replaced with new equivalent features. Deprecated Nan features have also been replaced. Besides being able to build in Node.js 12, all build warnings about deprecated functions are now fixed.
Motivation and Context
Node.js 12 will probably very soon be the next LTS. The changes in this PR are critical to make it possible for Node.js 12 projects using this library.
Fixes issue #153
How Has This Been Tested?
examples
folderconverters.h
)npm test
npm run integrationtest
(verbose output, skipped pasting here)
npm run test-components
Types of changes
Checklist: