Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: quicker build #191

Merged
merged 4 commits into from Jul 25, 2019
Merged

Conversation

@DavidVujic
Copy link
Collaborator

DavidVujic commented Jul 23, 2019

Description

This PR will enable a quicker build experience for Windows users. It will bypass CMake feature checks and will also hide compiler warnings in the output, by overwriting the default CMakeLists.txt.

There is an option to still use the default, by passing in the ZK_INSTALL_VERBOSE flag as described here.

Motivation and Context

To improve the developer experience on the Windows platform.
Fixes issue #182

How Has This Been Tested?

Travis CI build passed (Windows, Linux, Mac OS X)
Manual npm install in a Windows 10 virtual machine.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@jbienkowski311

This comment has been minimized.

Copy link
Contributor

jbienkowski311 commented Jul 24, 2019

Is the statement in the README still valid?

Also, run npm install in a Powershell window as an Administrator. For further instructions visit node-gyp documentation.

@DavidVujic

This comment has been minimized.

Copy link
Collaborator Author

DavidVujic commented Jul 24, 2019

@DavidVujic

This comment has been minimized.

Copy link
Collaborator Author

DavidVujic commented Jul 24, 2019

Checked manually that admin access is not necessary, by creating a standard user in windows and npm install.

@jbienkowski311

This comment has been minimized.

Copy link
Contributor

jbienkowski311 commented Jul 24, 2019

I guess it's result of your previous PR, but I stumbled upon it during the review of this one 😉

@DavidVujic DavidVujic merged commit 74d5481 into yfinkelstein:master Jul 25, 2019
@DavidVujic DavidVujic deleted the DavidVujic:windows_quicker_build branch Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.