Made ncc threshold adjustable

[njbradley]

This is a follow up from my question at #279, I put in a parameter in the stitch_images function to adjust the threshold manually. It isn't ready for merging yet, I haven't run the automated tests or written any tests for it, but in my usage it has worked well.

I am also not sure if exposing this value could cause other errors, (ie setting it to zero or very low values, or other edge cases).

Let me know what changes I should make!

[yfukai]

Hi @njbradley, thanks a lot for this contribution! I'm very happy 🥳

I haven't run the automated tests or written any tests for it, but in my usage it has worked well.

The tests are working at least on GitHub CI. Would you mind adding a test showing that changing this value actually changes the stitching result? (a failing data changes to succeed, or a succeeding data changes to fail. If you're OK with that you could add your data for test).

I am also not sure if exposing this value could cause other errors, (ie setting it to zero or very low values, or other edge cases).

At this point, I think we can make it the user's responsibility to adjust this value in a good range. I hope at some point I can make this a bit organized with validations and structured errors with pydantic or so (like for https://github.com/yfukai/laptrack ).

[yfukai]

Merged as it looks OK, I'll add the tests later, thanks @njbradley for your contribution!

[njbradley]

Oh thanks, I had forgotten about adding those tests! I'm glad I could help!