New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mis-Enabling Gradient In AdaNPC #7

Open

Cascol-Chen opened this issue Jan 11, 2024 · 0 comments

Cascol-Chen commented Jan 11, 2024 •

edited

Loading

Hi,

Thank you for your outstanding contribution. I'd like to bring to your attention a potential concern in implementation. It's possible that it might inadvertently enable gradient in adaptation (see the link below), leading to increased GPU memory consumption. Would you mind to have a check on this?
https://github.com/yfzhang114/AdaNPC/blob/282e4130fa4e88878e00197561eba508ffb81448/domainbed/adapt_algorithms.py#L510C5-L510C5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment