Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New line parsing not working correctly in 0.6.0 #35

Closed
JosefNemec opened this issue Oct 21, 2023 · 3 comments · Fixed by #36
Closed

New line parsing not working correctly in 0.6.0 #35

JosefNemec opened this issue Oct 21, 2023 · 3 comments · Fixed by #36

Comments

@JosefNemec
Copy link

In 0.5.0, following CLRF formatted string:

settings-restart-ask-message = 
    Playnite needs to be restarted in order to apply new settings. Restart now?
    
    Restarting will cancel any active tasks (downloads) currently in progress.

was returned properly as

Playnite needs to be restarted in order to apply new settings. Restart now?

Restarting will cancel any active tasks (downloads) currently in progress.

but 0.6.0 now returns:

Playnite needs to be restarted in order to apply new settings. Restart now?
Restarting will cancel any active tasks (downloads) currently in progress.

Full file I'm adding as a resource via File.ReadAllText : en_US.zip
@Ygg01
Copy link
Owner

Ygg01 commented Oct 22, 2023

Thanks for the heads up I'll see to fixing this ASAP.

Ygg01 added a commit that referenced this issue Oct 23, 2023
@Ygg01
Add test cases for #35
e575574
Ygg01 added a commit that referenced this issue Oct 23, 2023
@Ygg01
Fix CRLF newlines being consumed by the parser #35
084f6dd 
The issue is caused by newline special case CRLF being ignored by parser, when the line is empty.
@Ygg01 Ygg01 mentioned this issue Oct 23, 2023
Merged
@Ygg01 Ygg01 closed this as completed in #36 Oct 23, 2023
Ygg01 added a commit that referenced this issue Oct 23, 2023
@Ygg01
Add test cases for #35
8970a47
Ygg01 added a commit that referenced this issue Oct 23, 2023
@Ygg01
Fix CRLF newlines being consumed by the parser #35
948027a 
The issue is caused by newline special case CRLF being ignored by parser, when the line is empty.
@Ygg01
Copy link
Owner

Ygg01 commented Oct 24, 2023

@JosefNemec Did 0.6.1 fix the issue?

@JosefNemec
Copy link
Author

Works properly with 0.6.1, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Newlines fix Ygg01/Linguini
2 participants
@Ygg01 @JosefNemec