Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies (go modules) broken with Go 1.13 #535

Closed
Luzifer opened this issue Sep 4, 2019 · 3 comments
Closed

Dependencies (go modules) broken with Go 1.13 #535

Luzifer opened this issue Sep 4, 2019 · 3 comments
Milestone

Comments

@Luzifer
Copy link

Luzifer commented Sep 4, 2019

Go 1.13 changed version validation within Go modules which breaks <=0.3.8 tagged builds of Yggdrasil:

==> Extracting sources...
  -> Extracting yggdrasil-0.3.8.tar.gz with bsdtar
==> Starting build()...
Building: yggdrasil
go: github.com/hjson/hjson-go@v0.0.0-20181010104306-a25ecf6bd222: invalid pseudo-version: does not match version-control timestamp (2018-12-10T17:43:06Z)
==> ERROR: A failure occurred in build().
@neilalexander
Copy link
Member

This should be fixed already in the develop branch if you can check that?

@Luzifer
Copy link
Author

Luzifer commented Sep 4, 2019

Confirmed through build in golang:latest container: While master shows above mentioned issue, develop does not:

# docker run --rm -ti -v $(pwd):$(pwd) -w $(pwd) golang:latest
[...]
Status: Downloaded newer image for golang:latest

# go version
go version go1.13 linux/amd64

# go get ./cmd/yggdrasil
go: github.com/hjson/hjson-go@v0.0.0-20181010104306-a25ecf6bd222: invalid pseudo-version: does not match version-control timestamp (2018-12-10T17:43:06Z)

# git checkout develop
# go get ./cmd/yggdrasil
go: downloading github.com/kardianos/minwinsvc v0.0.0-20151122163309-cad6b2b879b0
go: downloading github.com/hashicorp/go-syslog v1.0.0
[...]
go: finding github.com/yggdrasil-network/water v0.0.0-20190812103929-c83fe40250f8
go: finding github.com/vishvananda/netns v0.0.0-20190625233234-7109fa855b0f

@neilalexander
Copy link
Member

OK, will close this for now since v0.3.9 will include the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants