Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(publish): add package.json for npm publishment #6

Closed
wants to merge 1 commit into from

Conversation

foreseaz
Copy link

No description provided.

@foreseaz
Copy link
Author

@ygoe oh sorry, I only wanted to push the package.json commit to this PR. The second commit is for my own modification and I pushed by mistake.

@ygoe
Copy link
Owner

ygoe commented Mar 10, 2019

Thank you for your effort. I didn't want to publish code I don't understand, and now I also need a package for this library. So I learned this stuff today and tried it out locally. It was easier to do it on my computer than merging this PR. The code needed to be modified to be Node/require-compatible and the documentation also needed to be updated. An npm package of msgpack.js is coming soon!

@ygoe ygoe closed this Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants