Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Fix for Prototype Pollution - huntr.dev #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

huntr-helper
Copy link

https://huntr.dev/users/d3m0n-r00t has fixed the Prototype Pollution vulnerability 馃敤. Think you could fix a vulnerability like this?

Get involved at https://huntr.dev/

Q | A
Version Affected | ALL
Bug Fix | YES
Original Pull Request | 418sec#1
Vulnerability README | https://github.com/418sec/huntr/blob/master/bounties/npm/simple-deep-assign/1/README.md

User Comments:

馃搳 Metadata *

Fixed Prototype pollution in simple-deep-assign.

Bounty URL: https://www.huntr.dev/bounties/1-npm-simple-deep-assign

鈿欙笍 Description *

simple-deep-assign is vulnerable to Prototype Pollution.

馃捇 Technical Description *

The package is vulnerable to Prototype pollution in the deepAssgin function. This vulnerability is fixed by filtering the keywords that causes pollution from the object.

馃悰 Proof of Concept (PoC) *

// poc.mjs
import deepAssign from 'simple-deep-assign';

console.log('Before: ', {}.polluted})
deepAssign({}, JSON.parse('{"__proto__": {"polluted": "Prototype Polluted"}}'));
console.log('After: ', {}.polluted})
Before: undefined
After: Prototype Polluted

Screenshot 2021-01-10 155540

馃敟 Proof of Fix (PoF) *

After fix:
Screenshot 2021-01-10 155751

馃憤 User Acceptance Testing (UAT)

All ok.

馃敆 Relates to...

Provide the URL of the PR for the disclosure that this fix relates to.

d3m0n-r00t and others added 2 commits January 10, 2021 15:59
Fixed Prototype pollution in simple-deep-assign
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants