Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document blocking functions #6

Open
darioteixeira opened this issue Sep 7, 2016 · 2 comments
Open

Document blocking functions #6

darioteixeira opened this issue Sep 7, 2016 · 2 comments
Assignees
Labels

Comments

@darioteixeira
Copy link

I'm taking a look at ocaml-mysql for interfacing with Google Cloud SQL. Since the application uses Lwt, I'm using Lwt_preemptive.detach to get around ocaml-mysql offering only a blocking API. There is one major hurdle with this approach, however: it's not always obvious which functions block on I/O and which ones don't. It would be nice if the API documentation for ocaml-mysql were explicit on this matter.

@ygrek
Copy link
Owner

ygrek commented Nov 12, 2016

I think this is better left of for the libmysqlclient documentation, to avoid duplication. For example some libmysqlclient internals might change and the function that was interacting with server may stop doing so or vice versa, do we really want to track all such cases?

@ygrek
Copy link
Owner

ygrek commented Jul 4, 2017

FWIW, my argument above doesn't look convincing to me now. But I am unlikely to work on this myself. Feel free to provide patch or close..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants