Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate duphandle #31

Closed
ygrek opened this issue May 6, 2018 · 2 comments
Closed

deprecate duphandle #31

ygrek opened this issue May 6, 2018 · 2 comments
Assignees
Labels

Comments

@ygrek
Copy link
Owner

ygrek commented May 6, 2018

See #30 for motivation.
Rationale:

  • it is assumed to be used very infrequently if at all
  • supporting duphandle requires keeping references to all ocaml values passed in setopts - and this price is paid by users not using duphandle at all (which is supposed to be vast majority)
  • it also puts extra burden on adding every new setopt
  • it is pretty easy to replicate its functionality explicitly on ocaml side just by grouping all setopts into a list or closure and applying on fresh handle
@ygrek ygrek added the question label May 6, 2018
@ygrek ygrek self-assigned this May 6, 2018
@nojb
Copy link
Contributor

nojb commented May 6, 2018

FWIW, I am strongly in favour of removing duphandle. Not necessary for a language like OCaml and adds a lot of complexity to the bindings.

ygrek added a commit that referenced this issue May 28, 2018
@ygrek
Copy link
Owner Author

ygrek commented Mar 16, 2019

going to remove in next release

@ygrek ygrek closed this as completed in aabf3d6 Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants