-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geom: improvements to the base class #175
Comments
There is an awful lot of code duplication (checking if all required aes are there, updating the layer dict,...) which could all go into a default method in geom which would then either call the 'plot_layer()' method ore could be called from there. |
I think the lack of an explicit distinction between the mappings (1st point) makes bugs such as #232 creep in. It is obvious we need the three distinctions, Incorporating the distinction may have to wait until after #221, but before then I can get some of the code duplication (2nd and 3rd points) out of the way. |
@glamp, I am working on the 2nd and 3rd points mentioned by @JanSchulz above, it involves;
Currently some geoms like |
I definitely don't think it hurts. While the goal is to keep consistent On Mon, Mar 10, 2014 at 4:57 AM, has2k1 notifications@github.com wrote:
|
This is merged in #252 |
Currently all arguments to subclasses to geom end up as
aes
ormanual_aes
, but sometimes this is not enough (see stat_function). There is also a lot of code duplication in each plot_layer function (checking, layer building)It would be nice to improve the abstract
geom
class:geom(aes(...))
), aes setting (viageom(color=red)
) and "other" stuff passed in (see stat_function)The text was updated successfully, but these errors were encountered: