Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve_sqlite_parameters #15

Closed
wants to merge 2 commits into from

Conversation

stonebig
Copy link
Contributor

Hello Greg,

its seems 'pandsql' omits to send parameters to sqlite motor, which would be nice to have.
Here is a separate fix proposal, and associated test.

mylist = [ ('a',1), ('b', 2)]
myanswer=42
result = sqldf("SELECT *, :myanswer FROM mylist",locals())
print (result)

@ghost ghost assigned glamp May 28, 2013
@stonebig
Copy link
Contributor Author

Yes, you're absolutely right. I discovered it later.
"def sqldf(q, env, inmemory=True): " is a better option.

@stonebig
Copy link
Contributor Author

The other on-liner of the patch, and the associated test, was the important point to get sqlite ":variable" way of parametrizing working.

@stonebig stonebig mentioned this pull request Jun 1, 2013
@stonebig stonebig closed this May 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants