Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParseAcceptEncoding tests failing when compiling the library #1087

Closed
Tachi107 opened this issue Nov 14, 2021 · 3 comments · Fixed by #1090
Closed

ParseAcceptEncoding tests failing when compiling the library #1087

Tachi107 opened this issue Nov 14, 2021 · 3 comments · Fixed by #1090

Comments

@Tachi107
Copy link
Contributor

Tachi107 commented Nov 14, 2021

Hi, I'm consistently getting test failures when building the library with Meson and cpp-httplib_compile=true.

ParseAcceptEncoding1, 2 and 3 are all failing.

When setting cpp-httplib_compile=false, no failures occur.

I've setup a CI job that tests the compiled library in a different branch to show the failures, you can find it here: #1088

@yhirose
Copy link
Owner

yhirose commented Nov 14, 2021

@Tachi107, thanks for the report. Since I don't use the compiled version at all on my any project, could you look into it deeper to see why it happens only on the compiled version? If it's hard to track down the reason, I am thinking to get rid of the feature, because it was requested by users for their benefit and too much for me to maintain it... (#287)
Thanks!

@Tachi107
Copy link
Contributor Author

Ok, I'll try to figure out why it happens :)

@Tachi107
Copy link
Contributor Author

Turns out the issue wasn't really related to the split script, but a small issue with the Meson build file. Basically, flags like -DCPPHTTPLIB_ZLIB_SUPPORT were only used for the compilation of the library, and not when actually using it in external code. This meant that users would use the library as if all the various extra feature weren't available, while they actually were. Simple fix, I'm preparing a PR now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants