New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement to multipart parser #1519
Conversation
I see that the build is failing because my tests are not compatible with the .h .cpp split script. I will look at it tomorrow. |
When running split.py the |
author Mathieu Gaillard <gaillard@adobe.com> 1678229209 -0800 committer Mathieu Gaillard <gaillard@adobe.com> 1689355104 -0700 Fix multipart Content-Type headers with both boundary and charset parameters Improve code readability Add missing forward declaration Add tests for parsing multipart responses Change set_boundary to take r-values or l-values Improve the parsing of attributes name, filename and filename* in the multipart parser Use lowercase to compare attribute names Fix typos (yhirose#1517) Remove useless regex
…answers, and allow testing of MultipartFormDataParser.
I added:
To allow testing the multipart form data parser without making it public. |
I fixed the code so that tests pass, could I get a review? |
@mgaillard I fixed this issue in a simpler way. Could you try the latest httplib.h in the master branch? Thanks! https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition |
I noticed the parsing of multipart forms had two issues:
This PR is my attempt at solving the problem. I noticed two issues are related to this piece of code: #1250 and #1212.