Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat paths with embedded NUL bytes as invalid in detail::is_valid_path #1765

Merged
merged 1 commit into from Jan 27, 2024
Merged

Treat paths with embedded NUL bytes as invalid in detail::is_valid_path #1765

merged 1 commit into from Jan 27, 2024

Conversation

wandernauta
Copy link
Contributor

I've tested this on Linux, but from what I could find, NUL should also not appear in paths on other platforms.

Also adds a test that demonstrates decode_url's behavior with %00.

Fixes #1763.

@yhirose yhirose merged commit 4ef9ed8 into yhirose:master Jan 27, 2024
4 checks passed
@yhirose
Copy link
Owner

yhirose commented Jan 27, 2024

Thanks for the fine contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detail::is_valid_path returns true for paths with embedded NULs
2 participants