Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with CPM package manager #297

Closed
trcwm opened this issue Apr 25, 2024 · 3 comments
Closed

Compatibility with CPM package manager #297

trcwm opened this issue Apr 25, 2024 · 3 comments

Comments

@trcwm
Copy link
Contributor

trcwm commented Apr 25, 2024

Thanks for making this awesome library!

When including cpp-peglib with the CPM package manager in a larger project, the top level project cannot find the include files because it points to the wrong location. This is easily fixed by changing the INTERFACE path of cpp-peglib in CMakeLists.txt from:

target_include_directories(peglib INTERFACE ${CMAKE_SOURCE_DIR})
to
target_include_directories(peglib INTERFACE ${CMAKE_CURRENT_SOURCE_DIR})

This will most likely also help other package managers that do not install but include the source.

Regards,
Niels.

@yhirose
Copy link
Owner

yhirose commented Apr 25, 2024

@trcwm thanks for the suggestion. Could you please send a pull request, since I am not a CMAKE expert? Thanks!

@trcwm
Copy link
Contributor Author

trcwm commented Apr 30, 2024

Submitted.

@trcwm
Copy link
Contributor Author

trcwm commented May 2, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants