Changed INTERFACE location to CMAKE_CURRENT_SOURCE_DIR for package ma… #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nager compatibility. CMAKE_SOURCE_DIR points to the top-level CMakeLists.txt, not to the subdir CMakeLists.txt, so when cpp-peglib is included in a project, the INTERFACE/include directory points to the wrong location.
|
@sum01, @jimmy-park, could you review this pull request for me? Thanks! |
jimmy-park
suggested changes
May 1, 2024
| @@ -18,7 +18,7 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Linux") | |||
| endif() | |||
|
|
|||
| add_library(peglib INTERFACE) | |||
| target_include_directories(peglib INTERFACE ${CMAKE_SOURCE_DIR}) | |||
| target_include_directories(peglib INTERFACE ${CMAKE_CURRENT_SOURCE_DIR}) | |||
There was a problem hiding this comment.
Suggested change
| target_include_directories(peglib INTERFACE ${CMAKE_CURRENT_SOURCE_DIR}) | |
| target_include_directories(peglib INTERFACE | |
| $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}> | |
| $<INSTALL_INTERFACE:${CMAKE_INSTALL_PREFIX}/include> | |
| ) |
We should separate include directories for build/install.
There was a problem hiding this comment.
Does it even matter if the lib isn't installed? Only the header itself is installed, there's no export for the lib.
There was a problem hiding this comment.
Oh I didn't check the whole CMakeLists.txt. This suggestion has no effect but I suggested it routinely.
There was a problem hiding this comment.
@jimmy-park so can we merge the original change by @trcwm as it is?
There was a problem hiding this comment.
@yhirose Yes, please ignore this suggestion.
sum01
approved these changes
May 1, 2024
jimmy-park
approved these changes
May 1, 2024
|
@trcwm @sum01 @jimmy-park thanks for your help! |
|
Issue #297 can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nager compatibility.
CMAKE_SOURCE_DIR points to the top-level CMakeLists.txt, not to the subdir CMakeLists.txt, so when cpp-peglib is included in a project, the INTERFACE/include directory points to the wrong location.