fix: missing fallback translation when no locale available #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yi-Xu-0100
reviewed
Feb 24, 2021
Comment on lines
+6
to
+7
| const fileName = | ||
| locale && localizationFiles.includes(`${locale}.json`) ? `${locale}.json` : 'en.json'; |
There was a problem hiding this comment.
Suggested change
| const fileName = | |
| locale && localizationFiles.includes(`${locale}.json`) ? `${locale}.json` : 'en.json'; | |
| const fileName = localizationFiles.includes(`${locale}.json`) ? `${locale}.json` : 'en.json'; |
It can deal with the undefined and empty string input.
yi-Xu-0100
reviewed
Feb 24, 2021
| @@ -5,6 +5,7 @@ import { conventionalCommitsTypes } from '../src/index'; | |||
| describe('conventionalCommitsTypes() function test', () => { | |||
| it.each([ | |||
| ['en.json', undefined], | |||
| ['en.json', 'unknown-locale'], | |||
There was a problem hiding this comment.
Suggested change
| ['en.json', 'unknown-locale'], | |
| ['en.json', ''], | |
| ['en.json', 'unknown-locale'], |
Add test for the empty string input.
|
@Fabio286 I will do the change by myself and publish it quickly. Thanks for your contribution. 👍 |
This was referenced Feb 24, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi dev,
today i discovered the existence of this translation package for conventional-commit-types with an exception from my Vistual Studio Code installation.
This PR should fix this bug by providing english as fallback localization when a there is no specific localization.