Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #738 #610 / Yi.Keymap.Emacs (moveE) #753

Closed
wants to merge 4 commits into from

Conversation

dnsl48
Copy link
Contributor

@dnsl48 dnsl48 commented Apr 19, 2015

Checks isearching before trying to finish it.
Before the fix, moveE always tried to isearchFinishWithE, which made setSelectionMarkPointB $ regionStart p0 (Yi/Search.hs:390) and broke selection.

Although the problem has been localized and fixed here, there is the second place where the problem might show itself: https://github.com/yi-editor/yi/blob/master/src/library/Yi/Search.hs#L390
I'm not a vim user, that's why I suppose that this selection marking might be there for vim mode, but it makes the corruption of emacs's mode selection when isearch is being stopped.

…ck on isearching before trying to finish it
@dnsl48
Copy link
Contributor Author

dnsl48 commented Apr 21, 2015

Yi.Search:390 was added in 48acb13...59adc14.
Also, it had msgE "mark saved where search started" so that it wasn't used to any internal purposes of the editor. Looks like it was there for highlighting.
Furthermore, this function was made for the Emacs mode exclusively. I don't know if emacs behaviour was different in 2007, but now it's not the same, so I suppose that we can delete this marking painlessly.

Fuuzetsu pushed a commit that referenced this pull request May 2, 2015
Closes #738, #610, #753

Signed-off-by: Mateusz Kowalczyk <fuuzetsu@fuuzetsu.co.uk>
@Fuuzetsu Fuuzetsu closed this in bdd1bf9 May 2, 2015
@Fuuzetsu
Copy link
Member

Fuuzetsu commented May 2, 2015

Seems to work, thanks. Squashed the commits into one because we don't need 3 fixup commits and also ammended the message slightly to adhere to usual git conventions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants