Fixes #738 #610 / Yi.Keymap.Emacs (moveE) #753
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks isearching before trying to finish it.
Before the fix,
moveE
always tried toisearchFinishWithE
, which madesetSelectionMarkPointB $ regionStart p0
(Yi/Search.hs:390) and broke selection.Although the problem has been localized and fixed here, there is the second place where the problem might show itself: https://github.com/yi-editor/yi/blob/master/src/library/Yi/Search.hs#L390
I'm not a vim user, that's why I suppose that this selection marking might be there for vim mode, but it makes the corruption of emacs's mode selection when isearch is being stopped.