Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make url resolving optional #59

Merged
merged 3 commits into from Nov 14, 2019

Conversation

andreyvolokitin
Copy link
Contributor

Sometimes the project has custom URL resolving strategy so URL resolving on the SASS side is undesired. I.e. in my case I use a concept of "source root" in my IDE to write all URLs inside SASS files relative to it, and not to the SASS file itself. Then my IDE knows how to resolve these URLs and I can skip writing ../../ chains to make URLs truly relative.

I rewrite URLs later with PostCSS for css-loader to resolve them, and have no problems. But with fast-sass-loader it breaks because it rewrites my URLs. I thought that making url resolving optional could be helpful in such cases

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.1%) to 83.914% when pulling e4474f7 on andreyvolokitin:optional-url-resolve into 324e8d6 on yibn2008:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.1%) to 83.914% when pulling e4474f7 on andreyvolokitin:optional-url-resolve into 324e8d6 on yibn2008:master.

@yibn2008 yibn2008 merged commit 3329f0b into yibn2008:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants