New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π¦ Crab as a collateral #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The limits look fine. They are set in base terms, so they are [1000..250000] USDC, [1..250] ETH, and [1000..250000] DAI.
@iamsahu, the CrabOracle and CrabJoin need to be added in Tenderly. |
To reduce the surface of attack the Join was redeployed with no flashLoan functionality. Also, the asset configuration was modified to make it work new Witch in the future. Proposed: Here is the tenderly fork of approve & execute. |
Unfortunately due to another config error it had to be proposed again: Here is the tenderly fork of approve & execute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go, proposal analysis
YPP-86 has been proposed again to update the witch parameters: |
Proposal
Enable crab strategy token as a collateral.
Background
Details
Following steps would be taken to get the strategy token as a collateral:
Here are the config parameters:
Testing
The change has been deployed on a mainnet fork here with the following output:
Here is the output of the tests: