remove unused group option for RQ

yifan · May 26, 2022 · 85b05bc · 85b05bc
1 parent 8c4a951
commit 85b05bc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/pipeline/backends/rq.py b/src/pipeline/backends/rq.py
@@ -18,7 +18,6 @@
 
 class RQSourceSettings(SourceSettings):
     redis: str = Field("redis://localhost:6379/0", title="redis url")
-    group: str = Field(..., title="redis consumer group name")
     min_idle_time: int = Field(
         3600000,
         title="messages not acknowledged after min-idle-time will be reprocessed",
@@ -30,7 +29,7 @@ class RQSource(SourceTap):
 
     >>> import logging
     >>> from unittest.mock import patch
-    >>> settings = RQSourceSettings(group="reader")
+    >>> settings = RQSourceSettings()
     >>> RQSource(settings=settings, logger=logging)
     RQSource(host="redis://localhost:6379/0", topic="in-topic")
     """
@@ -45,7 +44,6 @@ def __init__(
     ) -> None:
         super().__init__(settings, logger)
         self.settings = settings
-        self.group = settings.group
         self.topic = namespaced_topic(settings.topic, settings.namespace)
         self.timeout = settings.timeout
         self.redis = Redis.from_url(settings.redis)

diff --git a/tests/test_backends.py b/tests/test_backends.py
@@ -117,7 +117,7 @@ def test_rq(self, mock_redis):
         destination.close()
 
         source_and_settings_classes = SourceTap.of(TapKind.RQ)
-        settings = source_and_settings_classes.settings_class(group="group")
+        settings = source_and_settings_classes.settings_class()
         settings.parse_args("--in-topic test".split())
         source = source_and_settings_classes.source_class(settings)
         message_read = next(source.read())