-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for video files #14
Comments
Hi @rohantarai ! Thank you for raising this issue up! 😄 Thank you for your appreciation! I will add support for video files and publish a new version before the end of next week. 👨🏻💻 Rest assured that there will be no breaking changes. I will notify you for the new version. |
Hey @yifaneye , |
Hi @rohantarai , |
Hi @rohantarai , Issue #27 reminded me that you can use the "children" prop for placing video files into the carousel. Currently, the "children" prop is served as an option for "user-managed" slides. Since I believe that developer users may have their own markup and styles to be placed in each slide. For example, you can place your video file here to replace the text in the slide
Hope it helps! |
@yifaneye Hey sorry for late reply. As in the documentation it was not mentioned about using children prop to show video files, so i thought to tell you about adding feature for video files. |
Hi @rohantarai ! Thank you for pointing this out! You asked a very good question. 😀 I will enhance the documentation to mention about "using children prop to show video files". |
This is the best carousel library. but i would like to request a feature to support video files.
The text was updated successfully, but these errors were encountered: