Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for video files #14

Closed
rohantarai opened this issue Apr 25, 2021 · 6 comments
Closed

Support for video files #14

rohantarai opened this issue Apr 25, 2021 · 6 comments
Assignees
Labels
documentation Improvements or additions to documentation feature request New feature or request

Comments

@rohantarai
Copy link

This is the best carousel library. but i would like to request a feature to support video files.

@yifaneye yifaneye self-assigned this Apr 26, 2021
@yifaneye yifaneye added the feature request New feature or request label Apr 26, 2021
@yifaneye yifaneye added this to To do in react-gallery-carousel via automation Apr 26, 2021
@yifaneye yifaneye added this to the v0.1.6 milestone Apr 26, 2021
@yifaneye
Copy link
Owner

Hi @rohantarai ! Thank you for raising this issue up! 😄

Thank you for your appreciation! I will add support for video files and publish a new version before the end of next week. 👨🏻‍💻 Rest assured that there will be no breaking changes. I will notify you for the new version.

@rohantarai
Copy link
Author

Hey @yifaneye ,
Thanks for responding to my request. i am happy to see that you accepted it as an enhancement. Looking forward to use the video feature! :)

@yifaneye
Copy link
Owner

Hi @rohantarai ,
You're welcome! You will see the video feature before the end of next week.

@yifaneye yifaneye removed this from the v0.1.6 milestone May 2, 2021
@yifaneye
Copy link
Owner

yifaneye commented May 4, 2021

Hi @rohantarai ,

Issue #27 reminded me that you can use the "children" prop for placing video files into the carousel. Currently, the "children" prop is served as an option for "user-managed" slides. Since I believe that developer users may have their own markup and styles to be placed in each slide.

For example, you can place your video file here to replace the text in the slide

Hope it helps!

@rohantarai
Copy link
Author

@yifaneye Hey sorry for late reply. As in the documentation it was not mentioned about using children prop to show video files, so i thought to tell you about adding feature for video files.

@yifaneye
Copy link
Owner

Hi @rohantarai !

Thank you for pointing this out! You asked a very good question. 😀

I will enhance the documentation to mention about "using children prop to show video files".

@yifaneye yifaneye added the documentation Improvements or additions to documentation label May 14, 2021
react-gallery-carousel automation moved this from To do to Done May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature request New feature or request
Development

No branches or pull requests

2 participants