Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install doesnt work on react-gallery-carousel/example/ #72

Closed
damdafayton opened this issue May 1, 2022 · 3 comments
Closed

npm install doesnt work on react-gallery-carousel/example/ #72

damdafayton opened this issue May 1, 2022 · 3 comments
Assignees
Labels
bug Something isn't working cannot replicate We can't replicate the issue good first issue Good for newcomers
Milestone

Comments

@damdafayton
Copy link

damdafayton commented May 1, 2022

Describe the bug
I managed to install dependencies but I still get this error:

./src/components/Carousel1.js
Cannot find file: 'TwoWayMap.js' does not match the corresponding name on disk: '.\src\utils\twoWayMap.js'.

And there is no such file under \utils\

To Reproduce

npm install
npm start

Fix
import TwoWayMap from '../utils/TwoWayMap';
needs to be
import TwoWayMap from '../utils/twoWayMap';

@yifaneye
Copy link
Owner

yifaneye commented May 5, 2022

Hi @damdafayton ! Thank you for raising this issue up.

I can't reproduce your bug. But I see the difference in the naming. I will fix it.

@yifaneye yifaneye self-assigned this May 5, 2022
@yifaneye yifaneye added bug Something isn't working good first issue Good for newcomers cannot replicate We can't replicate the issue labels May 5, 2022
@yifaneye yifaneye added this to the v0.3.0 milestone May 5, 2022
@yifaneye
Copy link
Owner

Hi @damdafayton ! Sorry for the late reply!

SS 2022-10-14 at 22 54 53
SS 2022-10-14 at 22 45 44
The case in the name of the file is correct in the repo on my Mac. However, I can see that it is wrong in this GitHub repo and in my newly-cloned repo.
SS 2022-10-14 at 22 52 06
SS 2022-10-14 at 22 52 28

I will fix it this weekend.

@yifaneye yifaneye mentioned this issue Oct 15, 2022
@yifaneye
Copy link
Owner

Hi @damdafayton !

In v0.3.0, I corrected the case in the name of the file. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cannot replicate We can't replicate the issue good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants