Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex for function names w/metacharacters #33

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Conversation

joshuaulrich
Copy link
Collaborator

Rd2roxygen() throws an error if the function name contains a regex metacharacter (e.g. "[.data.frame") because the function name is inserted directly into the grep() regular expression.

This commit escapes all regex metacharacters. Fixes #32.

Rd2roxygen() throws an error if the function name contains a regex
metacharacter (e.g. "[.data.frame") because the function name is
inserted directly into the grep() regular expression.

This commit escapes all regex metacharacters.
Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

DESCRIPTION Outdated Show resolved Hide resolved
@yihui yihui merged commit 9d26cc5 into yihui:main Mar 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conversion fails if function name contains a regex metacharacter
2 participants