Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests still valid ? #72

Closed
cderv opened this issue Nov 18, 2020 · 2 comments
Closed

Integration tests still valid ? #72

cderv opened this issue Nov 18, 2020 · 2 comments

Comments

@cderv
Copy link
Collaborator

cderv commented Nov 18, 2020

Are the integration tests on branch still valid ?
https://github.com/yihui/knitr-examples#integration-tests

Following changes in knitr
yihui/knitr@16493ec#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485

I am not so sure this is possible to create a branch in a fork to get the test done.
It seems integration will happen only on master now. Example in one of the last travis jobs:
https://travis-ci.com/github/yihui/knitr/jobs/421565801

I think we won't be needed that at the examples will be checked for each PR (following yihui/knitr#1920), but we would still need a mechanism for someone to add a tests in knitr-examples and have it check when doing a knitr PR.

This issue is

  • To remind to update the README
  • Or adjust our CI worflow to make what is describe works again
@cderv
Copy link
Collaborator Author

cderv commented Nov 24, 2020

@yihui related to the PR you merged and knitr's one.

Know that the integration tests describe won't work anymore, but as explained above I don't think it was still working recently in Travis.

@yihui
Copy link
Owner

yihui commented Nov 24, 2020

It seems integration will happen only on master now.

That's correct. I'll remove that section in readme. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants