Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github actions instead of travis #1920

Merged
merged 27 commits into from
Nov 24, 2020
Merged

Use github actions instead of travis #1920

merged 27 commits into from
Nov 24, 2020

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Nov 17, 2020

  • Using r-lib/actions as template
  • Windows Linux and MacOS
  • We won't publish to XRAN - could be added later

Todod

  • Add a workflow to test knitr-examples - same as it is working now.
  • Debug knitr-examples workflow

Idea

  • It would be great to cache package installed for knitr-examples. It is currently 9 minutes.

Need to use mya fork and branch for now
This reverts commit f4d85cc.
@cderv
Copy link
Collaborator Author

cderv commented Nov 18, 2020

Status & Progress:

We got this after knitr-examples checks

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   025-engine-ruby.md
	modified:   027-engine-bash.md
	modified:   042-highlight-matlab.tex
	modified:   098-highlight-python.tex

Other failure are the one we found on Travis too :
https://travis-ci.com/github/yihui/knitr/jobs/432589388#L2759

	modified:   009-slides.md
	modified:   010-upload.md
	modified:   021-ggplot2-geoms.tex
	modified:   046-read-rforge.md
	modified:   093-knitr-asy.md
	modified:   106-polyglot.md

But they do not put the job in failure.

@cderv
Copy link
Collaborator Author

cderv commented Nov 18, 2020

On other note, I also removed some apt installation that where not needed (maybe they are already available in the runner)

  • The dev dependencies for packages are now found automatically by remotes::system_requirements("ubuntu", "18.04")
  • Some tools are already installed like cargo, ghc, texinfo.

There is only qpdf that does not seem to be installed already but was not required.

@cderv
Copy link
Collaborator Author

cderv commented Nov 20, 2020

It would be better to merge this after merging knitr-examples, which I can't do myself.

Next step would be

  • Do we need to fix highlight example ? Should we modify the resulting .md file due to the change we are seing in output ?
  • Merge change in knitr-examples once ok.
  • Modify the checkout of master in knitr-examples in the workflow in this PR
  • Merge this PR in knitr.

Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The highlight examples have been updated: yihui/knitr-examples@0262a05

Thanks!

@yihui yihui merged commit 3bc7920 into master Nov 24, 2020
@yihui yihui deleted the gha branch November 24, 2020 16:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants