Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a powershell script to locally knit example on Windows #82

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Add a powershell script to locally knit example on Windows #82

merged 1 commit into from
Nov 16, 2021

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Nov 16, 2021

Is this ok for you ?

Only used locally for now.

@cderv cderv requested a review from yihui November 16, 2021 14:01
yihui
yihui approved these changes Nov 16, 2021
View reviewed changes
Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

At some point I'd like to move the whole thing to an internal function knitr:::knit_example, so that we only need to call Rscript -e "knitr:::knit_example() in the shell script and powerscript.

@cderv cderv mentioned this pull request Nov 16, 2021
Open
@cderv
Copy link
Collaborator Author

cderv commented Nov 16, 2021

I added the idea in an issue and in the board

@cderv cderv merged commit 57f20d4 into master Nov 16, 2021
@cderv cderv deleted the powershell-k-script branch November 16, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihui yihui yihui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cderv @yihui