Replace several stringr-based function calls with base equivalents #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that it returns a character vector of the same length as the input vector
yihui
approved these changes
Dec 13, 2022
|
Thanks! Also really appreciate that you got rid of |
rich-iannone
added a commit
that referenced
this pull request
Dec 22, 2022
* master: make negative times 0 replace highr:::spaces() with strrep() in base R support chunk options message/warning = NA close #2204: drop the support for cairoDevice amend 1a0f2cc: make line_count() a few times faster Replace several stringr-based function calls with base equivalents (#2202, #1549) see if this fix the ruby gems issue https://github.com/yihui/knitr/actions/runs/3682745993/jobs/6230638404 stop importing xfun::isFALSE() and define isFALSE() only for R < 3.5.0 Add labels to the default progress bar and allow users to provide a custom progress bar (#2196)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces several uses of stringr functions with base equivalents. This is being done in order to eventually remove the dependency on the stringr package.