Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic integration testing #642

Merged
merged 70 commits into from
Nov 1, 2013
Merged

Automatic integration testing #642

merged 70 commits into from
Nov 1, 2013

Conversation

krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Oct 28, 2013

Subject to cleanup, but otherwise complete (#627)

@yihui
Copy link
Owner

yihui commented Oct 28, 2013

I guess I may not want this, since the knitr-examples repo requires a big toolchain (yihui/knitr-examples@7d4d10a), and may take a long time to install or compile. A few examples include rgl plots, which may require X to be available (not sure if travis has that). That said, you are welcome to try, and see if it really works on travis within 20 minutes. Thanks!

@krlmlr
Copy link
Contributor Author

krlmlr commented Oct 28, 2013

Thanks for your input. There's xpra which can be used as "X for headless machines".

@krlmlr
Copy link
Contributor Author

krlmlr commented Oct 28, 2013

Are you concerned about promptly receiving a success/failure notification? The knitr test could push a commit to a specially fabricated knitr-examples testing repository which triggers a (seemingly unrelated) test just for the examples.

@yihui
Copy link
Owner

yihui commented Oct 28, 2013

I remember travis has a time limit for 20 minutes, and I'm not sure if it can be done within this time.

@krlmlr
Copy link
Contributor Author

krlmlr commented Oct 28, 2013

It's been raised to 50 minutes.

@krlmlr
Copy link
Contributor Author

krlmlr commented Oct 28, 2013

Any chance we move knitr-examples back as a subdirectory to knitr? The submodule approach works, but it's rather tedious, cf. d136544 .

@yihui
Copy link
Owner

yihui commented Oct 28, 2013

I tend to add a .travis.yml in the knitr-examples repo instead. I want to keep it as a separate repo, since I have provided links to it in quite a few places on the web (it will be hard to correct all of them), and I probably do not want to check this repo every time I push to the knitr repo. It seems it will still take you quite a while to figure out all the dependencies of the knitr-examples repo :)

@krlmlr
Copy link
Contributor Author

krlmlr commented Oct 29, 2013

Integration test now counts number of different files and lines and checks against expected values (cf. this diff).

@krlmlr
Copy link
Contributor Author

krlmlr commented Oct 30, 2013

This pull request is in a "works for me" state. Shall we start discussing it?

@yihui
Copy link
Owner

yihui commented Oct 30, 2013

Yes, I'm still trying to catch up with your huge amount of work. You have been running too fast :)

yihui added a commit that referenced this pull request Nov 1, 2013
Automatic integration testing; closes #627
@yihui yihui merged commit 4cfbf96 into yihui:master Nov 1, 2013
@krlmlr krlmlr deleted the 627-integration branch November 1, 2013 10:20
@krlmlr krlmlr restored the 627-integration branch November 2, 2013 01:36
@krlmlr krlmlr deleted the 627-integration branch November 2, 2013 01:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants