Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support self-contained images in xaringan slides (close #3) #207

Merged
merged 26 commits into from Sep 24, 2020
Merged

Support self-contained images in xaringan slides (close #3) #207

merged 26 commits into from Sep 24, 2020

Commits on Apr 16, 2019

  1. self-contained images for xaringan, with tests

    Susan Vanderplas committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    dda23ac View commit details
    Browse the repository at this point in the history

  2. update news/description/documentation

    Susan Vanderplas committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    7040fc1 View commit details
    Browse the repository at this point in the history

  3. fix space issues in regex

    Susan Vanderplas committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    db3832e View commit details
    Browse the repository at this point in the history

  4. Better error checking - ensure file exists before passing to URI enco… 

    …ding, issue warning if file does not exist
    Susan Vanderplas committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    080510e View commit details
    Browse the repository at this point in the history

  5. add documentation

    Susan Vanderplas committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    2852aa0 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2019

  1. fix tests, detect file extension, add test of local file as well.

    Susan Vanderplas committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    1c82537 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2020

  1. Fix rebase

    Susan Vanderplas committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    3c586cb View commit details
    Browse the repository at this point in the history

  2. fix names

    Susan Vanderplas committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    425c2c2 View commit details
    Browse the repository at this point in the history

  3. Fix tests

    Susan Vanderplas committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    f7f6f7c View commit details
    Browse the repository at this point in the history

  4. Better error checking - ensure file exists before passing to URI enco… 

    …ding, issue warning if file does not exist
    Susan Vanderplas committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    b7bc388 View commit details
    Browse the repository at this point in the history

  5. add documentation

    Susan Vanderplas committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    815594b View commit details
    Browse the repository at this point in the history

  6. handle local files, fix tests

    Susan Vanderplas committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    bd88cee View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' of https://github.com/srvanderplas/xaringan

    Susan Vanderplas committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    bc276c6 View commit details
    Browse the repository at this point in the history

  8. updated documentation, remove tests that were redundant.

    Susan Vanderplas committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    5b52b88 View commit details
    Browse the repository at this point in the history

  9. Format to 80 chars... only exception is the giant regex

    Susan Vanderplas committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    fb35427 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. revert irrelevant changes 

    I'm not religious about the width 80
    @yihui
    yihui committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    e61e2e8 View commit details
    Browse the repository at this point in the history

  2. add person() back

    @yihui
    yihui committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    e96165b View commit details
    Browse the repository at this point in the history

  3. adjust order, and not sure why these two ctb's were added

    @yihui
    yihui committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    377bec9 View commit details
    Browse the repository at this point in the history

  4. don't support <img></img> because the img tag shouldn't be closed by … 

    …</img>; just <img />
    @yihui
    yihui committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    7b65afa View commit details
    Browse the repository at this point in the history

  5. rename process_self_contained_images to encode_images(), and replace … 

    …<- with =
    @yihui
    yihui committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    143d09e View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. the full implementation of self-contained slides: the basic idea is t… 

    …o find out images, base64 encode them, store the data in a JSON object, replace the original image URLs with special tokens that contain the original URLs; then in the browser, restore these tokens with the actual base64 data after the slides are rendered

rendering slides should be fast because the Markdown content is still lightweight (contains no base64 data); Markdown content containing base64 data used to be the main bottleneck when rendering self-contained slides, because these huge base54 strings make it really slow for remark.js to render them
    @yihui
    yihui committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    6b2b6b3 View commit details
    Browse the repository at this point in the history

  2. factor out a helper function, and a string token

    @yihui
    yihui committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    2287916 View commit details
    Browse the repository at this point in the history

  3. update tests

    @yihui
    yihui committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    7af7873 View commit details
    Browse the repository at this point in the history

  4. update doc

    @yihui
    yihui committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    d3ce953 View commit details
    Browse the repository at this point in the history

  5. update news

    @yihui
    yihui committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    4ede020 View commit details
    Browse the repository at this point in the history

  6. p -> P

    @yihui
    yihui committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    4066070 View commit details
    Browse the repository at this point in the history