fix $_SESSION data loss on multiple subsequent `DummySession::open(…

…)` invocations
yii1tech · Jun 14, 2023 · 7cedc8e · 7cedc8e
1 parent d53574c
commit 7cedc8e
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,12 @@
 Yii1 Dummy Session extension
 ============================
 
+1.0.1 Under Development
+-----------------------
+
+- Bug: Fixed `$_SESSION` data loss on multiple subsequent `DummySession::open()` invocations (klimov-paul)
+
+
 1.0.0, June 13, 2023
 --------------------
 

diff --git a/src/DummySession.php b/src/DummySession.php
@@ -37,8 +37,10 @@ public function init(): void
      */
     public function open()
     {
-        $this->_id = uniqid();
-        $_SESSION = [];
+        if ($this->_id === null) {
+            $this->_id = uniqid();
+            $_SESSION = [];
+        }
     }
 
     /**

diff --git a/tests/DummySessionTest.php b/tests/DummySessionTest.php
@@ -20,6 +20,24 @@ public function testOpenSession(): void
         $this->assertNotEmpty($session->getSessionID());
     }
 
+    /**
+     * @depends testOpenSession
+     */
+    public function testMultipleOpenSession(): void
+    {
+        $session = new DummySession();
+
+        $session->open();
+
+        $_SESSION['foo'] = 'bar';
+        $sessionId = $session->getSessionID();
+
+        $session->open();
+
+        $this->assertNotEmpty($_SESSION);
+        $this->assertEquals($sessionId, $session->getSessionID());
+    }
+
     /**
      * @depends testOpenSession
      */