This repository has been archived by the owner on Jan 10, 2022. It is now read-only.
Add SerialColumn #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public function renderHeaderCellContent() | ||
| { | ||
| return parent::renderHeaderCellContent(); |
There was a problem hiding this comment.
This code is redundant: what the sense of redeclaring method just to call for its parent implementation?
|
Closed, since there is no response from the author. |
|
Hi @klimov-paul, I sincerely apologize for my lack of feedback. I see you have implemented the SerialColumn now. I really hoped I would get around to replying and fixing the issues mentioned 😞, but for some reason I couldn't get to. Thank you for your awesome Yii2 extension, I hope I can contribute sometime in the future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement to provide SerialColumn functionality as the Yii2 SerialColumn doesn't. See issue #2.