Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added global 'void' function #3

Merged
merged 1 commit into from Oct 13, 2011
Merged

Added global 'void' function #3

merged 1 commit into from Oct 13, 2011

Conversation

svyatov
Copy link
Contributor

@svyatov svyatov commented Oct 13, 2011

Added global 'void' function to make possible to call functions and methods which return non-string result

@samdark
Copy link
Member

samdark commented Oct 13, 2011

I'm not sure if "void" is a good name. I think "php" will be better. Additionally, I think, people that care about their template security will not be happy if this function will be always available. Should be a way to disable it.

@svyatov
Copy link
Contributor Author

svyatov commented Oct 13, 2011

Why 'php'? This is just a wrapper that returns nothing and does nothing, like javascript:void(some code)... There is no problem to make it optional, but what is the problem with security? I don't get it.

samdark added a commit that referenced this pull request Oct 13, 2011
Added global 'void' function
@samdark samdark merged commit 7881092 into yiiext:master Oct 13, 2011
@samdark
Copy link
Member

samdark commented Oct 13, 2011

Now I've got it.

@svyatov
Copy link
Contributor Author

svyatov commented Oct 13, 2011

Cool, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants