Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sticky main navigation causes problem with hashlinks #35

Closed
cebe opened this issue Apr 16, 2015 · 3 comments
Closed

Sticky main navigation causes problem with hashlinks #35

cebe opened this issue Apr 16, 2015 · 3 comments
Milestone
launch

Comments

@cebe
Copy link
Member

cebe commented Apr 16, 2015

Currently the main navigation causes problems with hash links. linking to a section in the guide or to a method will hide the headline behind the navigation.

two possible solutions:

  1. disable stickyness of navigation
  2. add some JS that scrolls down 74px every time the hash changes
@cebe cebe added this to the launch milestone Apr 16, 2015
@qiangxue
Copy link
Contributor

Also need to consider the mobile view. I tend to option 1.

@samdark
Copy link
Contributor

samdark commented Apr 17, 2015

Same here.

@cebe
Copy link
Member Author

cebe commented May 25, 2015

mobile view is already covered by bootstrap, it is not sticky there.

@cebe cebe closed this as completed in 8d82ac6 Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
launch
Development

No branches or pull requests
3 participants
@samdark @cebe @qiangxue