Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to translator changes #149

Merged
merged 5 commits into from
Nov 18, 2022
Merged

Adapt to translator changes #149

merged 5 commits into from
Nov 18, 2022

Conversation

rustamwin
Copy link
Member

Q A
Is bugfix? ❌
New feature? ✔️/❌
Breaks BC? ✔️/❌
Fixed issues comma-separated list of tickets # fixed by the PR, if any

@rustamwin rustamwin added the status:code review The pull request needs review. label Nov 9, 2022
@rustamwin rustamwin requested a review from a team November 9, 2022 04:05
@what-the-diff
Copy link

what-the-diff bot commented Nov 9, 2022

  • Update yiisoft/translator to 2.0
  • Remove IntlMessageFormatter from the DI container definition and add it as a tag instead

vjik
vjik requested changes Nov 10, 2022
View reviewed changes
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need adopt params also.

@samdark
Copy link
Member

samdark commented Nov 18, 2022

Build seems to fail.

@rustamwin
Copy link
Member Author

Build seems to fail.

Now green :)

@rustamwin rustamwin merged commit 515a5f7 into master Nov 18, 2022
@rustamwin rustamwin deleted the adapt-translator branch November 18, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjik vjik vjik requested changes

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rustamwin @samdark @vjik