Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add functionality addValue #137

Merged
merged 26 commits into from
Nov 7, 2023
Merged

add functionality addValue #137

merged 26 commits into from
Nov 7, 2023

Conversation

Kutuzovska
Copy link
Contributor

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Fixed issues #136

Copy link

what-the-diff bot commented Nov 5, 2023

PR Summary

  • New 'addValue' method in ArrayHelper class
    A new function called 'addValue' has been added to the ArrayHelper class. This feature allows for the addition of values to specific array paths, even creating the path if it doesn't already exist. This is useful when you need to store information in an array and need a fixed path to it. Additionally, it smartly handles any situations where the value may already exist, setting this existing value as the lead element in the array to keep track.

  • New 'AddValueTest' file for testing
    Along with the new method, a new file named 'AddValueTest.php' has been created for proper testing. This file is specifically designed to conduct tests for the 'addValue' method ensuring its correctness and smooth operation.

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff29fb0) 99.75% compared to head (d54ccaa) 99.75%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #137   +/-   ##
=========================================
  Coverage     99.75%   99.75%           
- Complexity      200      208    +8     
=========================================
  Files             4        4           
  Lines           400      415   +15     
=========================================
+ Hits            399      414   +15     
  Misses            1        1           
Files Coverage Δ
src/ArrayHelper.php 99.67% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik added the status:code review The pull request needs review. label Nov 5, 2023
@vjik vjik requested a review from a team November 5, 2023 19:08
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
Kutuzovska and others added 5 commits November 7, 2023 10:18
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Copy link
Contributor Author

@Kutuzovska Kutuzovska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs fix

Kutuzovska and others added 9 commits November 7, 2023 10:22
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
Kutuzovska and others added 3 commits November 7, 2023 14:43
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
Copy link
Contributor Author

@Kutuzovska Kutuzovska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accept

Copy link
Contributor Author

@Kutuzovska Kutuzovska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add fix

@vjik vjik merged commit 0214e4b into yiisoft:master Nov 7, 2023
18 of 19 checks passed
@vjik
Copy link
Member

vjik commented Nov 7, 2023

@Kutuzovska Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants